[FFmpeg-devel] maintainer duties (was: Re: [PATCH] fix speex sample)

Baptiste Coudurier baptiste.coudurier
Sun Apr 12 00:57:04 CEST 2009

On Sun, Apr 12, 2009 at 12:49:53AM +0200, Reimar D?ffinger wrote:
> On Sat, Apr 11, 2009 at 03:42:41PM -0700, Baptiste Coudurier wrote:
> > On Sat, Apr 11, 2009 at 09:23:49AM -0400, Ronald S. Bultje wrote:
> > > Hi,
> > > 
> > > On Sat, Apr 11, 2009 at 7:49 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > > It has been decided to put the palette in the AVPackets
> > > > how to do this is a question per decoder and per demuxer, some may have a
> > > > natural way to pass the palette, some might even say in a spec how to do it
> > > > (though i guess that would be the exception if it applies to any at all)
> > > > the rest could just have a 'P'<len> vs. 'D' prefixed to packets
> > > 
> > > I think I said this before, I don't like this (conceptually). Can't we
> > > just add a PKT_FLAG_PALETTE? It's exactly the same as a prefix, except
> > > that it does not actually touch the bitstream. Now that Thilo added
> > > all these AVPackets to the decode() functions, let's use them.
> > 
> > I agree with the principle. I'm more in favor of
> > AVPacket->palette_data field.
> If you look at the current situation, most places where AVPaletteControl
> is used are actually doing quite a bit of "decoding" in the demuxer.
> A AVPacket->palette_data would invite the same kind of thing, so it
> would require at least a documentation entry like "if you ever use this
> when you do not absolutely have to we will send a grue to you to eat you!"

I agree with this.

I believe an exhaustive survey should be done to have a good picture
of how exactly palette is used.

For Quicktime, once the multiple stsd will be in, palette will be in
extradata for each stream. I don't know AVI muxer but if palette at
the end of bmp header, it should be in extradata as well.

Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA    
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org

More information about the ffmpeg-devel mailing list