[FFmpeg-devel] [PATCH] RTP/Vorbis payload implementation (GSoC qual task)

[Luca Barbato]

Colin McQuillan wrote:
> This patch implements Vorbis over RTP.

Nice!

> I've been testing against a Feng server so far, and only implemented
> the features necessary for Feng. I started from rtp_h264.c and the
> hints on the Small FFmpeg Tasks description.
> 
> On my sample ogg my patched ffmpeg stutters but I think that's just
> Feng.

I will have to have a look on it as soon I complete the move to libev 
for that part.

> I also get the same choppiness in Totem, which uses gstreamer's
> RTP Vorbis implementation.

I see.

Early and quick review follows.

+/**
+ * Length encoding described in RFC5215 section 3.1.1.
+ */
+static int read_base128(uint8_t ** buf, uint8_t * buf_end)
+{
+    int n = 0;
+    for (; *buf < buf_end; ++*buf) {
+        n <<= 7;
+        n += **buf & 0x7f;
+        if (!(**buf & 0x80)) {
+            ++*buf;
+            return n;
+        }
+    }
+    return 0;
+}

You should use the implementation that's already present in ffmpeg.

+/* ---------------- public code */

I'd call it otherwise.

the rest looks fine, I still have to try it.

lu

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero