[FFmpeg-devel] [PATCH] QCELP decoder postfilter & final gain control

Reynaldo H. Verdejo Pinochet reynaldo
Sun Apr 12 18:39:32 CEST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

M?ns Rullg?rd wrote:
> 
> Merely calculating an address outside an array or dynamically
> allocated block might cause an overflow trap or similar.  I have seen
> this happen in a real system, and it was not easy to track it down.

That's what I feared but had no practical proof on that regard. I
also think that even while not absolutely sure them would fail these
borderline, syntactical 'tricks' aren't generally worth their risk.

Kenan, would you please update your patch accordingly? While you
are at it I will fix the outstanding occurrences of this in the
celp code.

Bests
- --

Reynaldo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkniGUQACgkQwY4HfzEURSrgxgCfYRMnbmp45pNbn27GdJxxRbvs
QyAAn3Dc/LRP6NbxUZ+tittKDIPhcOkx
=OJDm
-----END PGP SIGNATURE-----



More information about the ffmpeg-devel mailing list