[FFmpeg-devel] [PATCH] Indeo5 decoder

Michael Niedermayer michaelni
Mon Apr 13 15:09:54 CEST 2009


On Mon, Apr 13, 2009 at 12:54:33PM +0200, Maxim wrote:
> Diego Biurrun schrieb:
> > On Mon, Apr 06, 2009 at 08:41:57PM +0200, Maxim wrote:
[...]
> >
> >> +            if (!p) {
> >> +                band->quant_mat = (i > 1) ? i+1 : 0;
> >> +            } else {
> >> +                band->quant_mat = 5;
> >> +            }
> >>     
> >
> > redundant {}
> >   
> 
> Ok, I just want to clarify that case:
> I corrected this statement after the patcheck showed me at that and some
> other places the following message:
> 
> missing } prior to else
> 
> I noticed that both "if" and "else" statements contain only one line
> therefore I made it conform to the "fully bracketed syntax" where both
> parts are enclosed in brackets. How should I act in such cases: "ignore"
> the patcheck's comments or use the "fully bracketed syntax"?

if(){
    one line
} else
   another line

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090413/79412def/attachment.pgp>



More information about the ffmpeg-devel mailing list