[FFmpeg-devel] GSoC Qual VQA v3 : updated patch.

[The Deep Explorer]

>> ===================================================================
>> --- libavcodec/vqavideo.c     (revision 18493)
>> +++ libavcodec/vqavideo.c     (working copy)
>> @@ -89,13 +89,16 @@
>>  #define CPL0_TAG MKBETAG('C', 'P', 'L', '0')
>>  #define CPLZ_TAG MKBETAG('C', 'P', 'L', 'Z')
>>  #define VPTZ_TAG MKBETAG('V', 'P', 'T', 'Z')
>> -
>
> Cosmetics.
>
>> +#define VPTR_TAG MKBETAG('V', 'P', 'T', 'R')
>> +#define VPRZ_TAG MKBETAG('V', 'P', 'R', 'Z')
>>  #define VQA_DEBUG 0
>>
>>  #if VQA_DEBUG
>>  #define vqa_debug printf
>>  #else
>> -static inline void vqa_debug(const char *format, ...) { }
>> +static inline void vqa_debug(const char *format, ...)
>> +{
>> +}
>
> Cosmetics.
>
>>  #endif
>>
>>  typedef struct VqaContext {
>> @@ -108,15 +111,15 @@
>>
>>      uint32_t palette[PALETTE_COUNT];
>>
>> -    int width;   /* width of a frame */
>> -    int height;   /* height of a frame */
>> -    int vector_width;  /* width of individual vector */
>> -    int vector_height;  /* height of individual vector */
>> -    int vqa_version;  /* this should be either 1, 2 or 3 */
>> +    int width;                  /* width of a frame */
>> +    int height;                 /* height of a frame */
>> +    int vector_width;           /* width of individual vector */
>> +    int vector_height;          /* height of individual vector */
>> +    int vqa_version;            /* this should be either 1, 2 or 3 */
>
> Cosmetics.
>
> And so on for most hunks.
>
> Cosmetics changes are not forbidden but (if and *only* if they make
> sense) they should be sent as different patches.
>
> Please read again the patch submission guidelines and learn them by
> heart, those rules are there to improve code quality and simplify the
> review process.
>
> If you really can't resist on doing cosmetics changes (e.g. realigning
> stuff and K&R consistency) do it in separate patches/threads, but I'll
> avoid them and focus only on functional changes, or you'll get swamped
> in some nitpickety fight.
>
> Regards.
> --

Honestly, I did not introduce those changes , which I am trying to
revert now manually :(...
the indent tool I guess did it which I applied as recommended :( ...I
dont even know
how to revert back without losing my changes..

Thanks Stefano for the advise.

Regards,
-tde