[FFmpeg-devel] [PATCH] RTSP-MS 15/15: move packet_time_start zero value assignment in asf.c

Michael Niedermayer michaelni
Thu Apr 16 00:04:43 CEST 2009

On Wed, Apr 15, 2009 at 02:16:44PM -0400, Ronald S. Bultje wrote:
> Hi,
> On Wed, Apr 15, 2009 at 1:07 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > the whole smells a little like h263 in rtp where some people also belive
> > dumped rtp payloads are a valid h263 stream
> You just said you wanted that three emails ago:
> "sorry its your code that is the mess much more than asf.c is
> its you who wants to leave the variable in an undefined state in case
> of error returns (and it IS used by other functions afterwards)
> its you who want to let RT*P call internal asf functions, why do you
> not cleanly instantiate a asf demuxer and use it through the common
> API that all demuxers use?"
> Did I misunderstand? If so, how?

I see no contradiction in what i said
First just said "use the asf code through its public API"
second just said "pass valid asf data to the asf demuxer"

first you seem to have achived, for the second now you must either fix
the data you pass or fix the demuxer
eof checks are not checks for non padded packets because ther is just
one eof not several in normal files

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090416/a7ef4d5c/attachment.pgp>

More information about the ffmpeg-devel mailing list