[FFmpeg-devel] [PATCH] EA TGQ video fixes

Reimar Döffinger Reimar.Doeffinger
Thu Apr 16 19:13:00 CEST 2009


On Thu, Apr 16, 2009 at 07:01:25PM +0200, Reimar D?ffinger wrote:
> On Thu, Apr 16, 2009 at 06:26:27PM +0200, Vitor Sessak wrote:
> > Index: libavcodec/eatgq.c
> > ===================================================================
> > --- libavcodec/eatgq.c	(revision 18249)
> > +++ libavcodec/eatgq.c	(working copy)
> > @@ -144,7 +144,7 @@
> >      int mode;
> >      int i;
> >      int8_t dc[6];
> > -    DCTELEM block[6][64];
> > +    DECLARE_ALIGNED_8(DCTELEM, block[6][64]);
> >  
> >      mode = bytestream_get_byte((const uint8_t**)bs);
> >      if (mode>buf_end-*bs) {
> 
> Moving it into the context instead should be more reliable.

Also if you check with dsputil.h you will see that idct_put needs 16
bytes alignment, not 8.

> Also it would be interesting to know on which platforms the results
> differ from which.

Well, at least PPC seems to differ from the results in the test
specification but x86_64 matches.



More information about the ffmpeg-devel mailing list