[FFmpeg-devel] [PATCH] Fix return value for sws_setColorspaceDetails()
Fri Apr 17 00:11:43 CEST 2009
On date Thursday 2009-04-16 20:21:31 +0200, Michael Niedermayer encoded:
> On Thu, Apr 16, 2009 at 06:05:29PM +0200, Stefano Sabatini wrote:
> > On date Tuesday 2009-04-14 11:57:14 +0200, Stefano Sabatini encoded:
> > > Hi,
> > > I'm still in the process of figuring out how the whole thing works,
> > > but the fix looks obvious.
> > >
> > > Regards.
> > > --
> > > FFmpeg = Fostering & Friendly Mind-dumbing Purposeless Ecumenical Geisha
> > > Index: ffmpeg/libswscale/swscale.c
> > > ===================================================================
> > > --- ffmpeg.orig/libswscale/swscale.c 2009-04-14 11:54:53.000000000 +0200
> > > +++ ffmpeg/libswscale/swscale.c 2009-04-14 11:54:57.000000000 +0200
> > > @@ -2299,7 +2299,7 @@
> > > c->saturation= saturation;
> > > c->srcRange = srcRange;
> > > c->dstRange = dstRange;
> > > - if (isYUV(c->dstFormat) || isGray(c->dstFormat)) return 0;
> > > + if (isYUV(c->dstFormat) || isGray(c->dstFormat)) return -1;
> > >
> > > c->uOffset= 0x0400040004000400LL;
> > > c->vOffset= 0x0400040004000400LL;
> > Ping?
> what about fixing the case instead of failing?
I have no time for a full fix now but maybe later (uh what about after
libavfilter integration ;-)), also if you have a plan for fixing it I
as well as others I think would be interested to hear it, as I already
said I'm quite naive about the lsws internals.
So I suggest to immediately apply the patch, at least it fixes the
FFmpeg = Fundamentalist Funny Merciful Pacific Evangelical Ghost
More information about the ffmpeg-devel