[FFmpeg-devel] [PATCH] asf*.c/h: use AVFormatContext->packet_size instead of own copy

Michael Niedermayer michaelni
Wed Apr 22 19:33:18 CEST 2009

On Wed, Apr 22, 2009 at 11:42:47AM -0400, Ronald S. Bultje wrote:
> Hi,
> On Wed, Apr 22, 2009 at 10:57 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Apr 22, 2009 at 10:42:40AM -0400, Ronald S. Bultje wrote:
> >> On Wed, Apr 22, 2009 at 10:02 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > changing the packet_size to signed is rejected
> >>
> >> What if I make AVFormatContext->packet_size unsigned? Seems like it's
> >> always incorrect.
> >
> > that could be considered
> Before I make myself look stupid and submit the obvious patch, could
> you elaborate on the considerations that I should attach to your
> "could"? We're not changing any alignment by adding an unsigned, but
> technically we are sort of breaking "ABI" because we change the
> meaning of <0 (from undefined/invalid to big). That needs no version
> bump, right?

no but i have to review the code to make sure its safe (i dont trust you
when it comes to spoting sec holes)


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090422/7628f61f/attachment.pgp>

More information about the ffmpeg-devel mailing list