[FFmpeg-devel] [PATCH] Prefer "monowhite"/"monoblack" over "monow"/"monob"
Thu Apr 23 23:52:01 CEST 2009
On date Wednesday 2009-04-01 02:12:44 +0200, Stefano Sabatini encoded:
> On date Wednesday 2009-04-01 02:02:35 +0200, Michael Niedermayer encoded:
> > On Wed, Apr 01, 2009 at 01:47:29AM +0200, Stefano Sabatini wrote:
> > > Hi,
> > >
> > > the names are more explicative and consistent with the corresponding
> > > pixel formats macros.
> > iam against this chnage, its also called rgb abd not redgreenblue
> PIX_FMT_ARGB -> "argb"
> PIX_FMT_MONOWHITE -> "monow"
> "monow" and "monob" are the only exceptions to the pixel format
> macro/name correspondence.
Sorry to bother again for this, I was almost committing the pixdescs
definition, I noted you used "monoblack" for the PIX_FMT_MONOBLACK
pixdesc, this maybe means that your subconsious agrees with me that
there should be a *strict* correspondance between PIX_FMT_ macros and
names, or we should fix that.
BTW the same PIX_FMT_/"name" inconsistency also happens for other
formats, follows the complete list:
PIX_FMT_MONOWHITE -> "monow"
PIX_FMT_MONOBLACK -> "monob"
PIX_FMT_GRAY8 -> "gray"
PIX_FMT_XVMC_MPEG2_MC -> "xvmcmc"
PIX_FMT_XVMC_MPEG2_IDCT -> "xvmcidct"
So the question is: should we keep this in pixdescs too or should we
normalize PIX_FMT_ macros and names?
I already pedantically expressed my position.
FFmpeg = Friendly Faithful Mastodontic Peaceless Elastic Genius
More information about the ffmpeg-devel