[FFmpeg-devel] Suggestion for a centralized language-tag facility in libavformat

cyril comparon cyril.comparon
Fri Apr 24 20:38:20 CEST 2009


>> + ? ? ? ? ? ? ? ?get_str16_nolen(pb, lang_len, lang, sizeof(lang));
>> + ? ? ? ? ? ? ? ?if (j < 128)
>> + ? ? ? ? ? ? ? ? ? ?asf->stream_languages[j] = av_strdup(lang);
>> + ? ? ? ? ? ?}
>
> instead of av_strdup() the initial array could be correctly allocated
> also this code leaks, if there are 2 ff_asf_language_guids
>

Fixed

>> + ? ? ? ?}
>> + ? ? ? ?end_header(pb, hpos);
>> + ? ?}
>
> trailing whitespace
>

Fixed

I attach only the impacted patch.
Cyril
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2_asf_languages-d.patch
Type: application/octet-stream
Size: 9609 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090424/be5d1f9b/attachment.obj>



More information about the ffmpeg-devel mailing list