[FFmpeg-devel] [PATCH] TwinVQ decoder
Diego Biurrun
diego
Sun Aug 2 18:27:53 CEST 2009
On Sun, Aug 02, 2009 at 06:25:16PM +0200, Vitor Sessak wrote:
> Reimar Doeffinger wrote:
> >On Sun, Aug 02, 2009 at 03:18:02PM +0200, Vitor Sessak wrote:
> >> for (i=step; i <= size - 2*step; i += step) {
> >
> >Missing spaces.
>
> where?
Around operators of course; you are inconsistent.
> >> interpolate(out + i-step + 1, out[i], out[i-step], step - 1);
> >> interpolate(out+i-step +1, out[i-step/2], out[i-step ],
> >> step/2-1);
> >> interpolate(out+i-step/2+1, out[i ], out[i-step/2],
> >> step/2-1);
> >> interpolate(out +size - 2*step+1, out[size-step], out[size-2*step],
> >> step-1);
> >
> >You don't place spaces particularly consistently...
>
> I hate breaking lines more than I like consistent spaces :(
Please avoid inconsistent formatting, it hurts readability.
Diego
More information about the ffmpeg-devel
mailing list