[FFmpeg-devel] [PATCH] getenv & strerror should be a NOP on WinCE

İsmail Dönmez ismail
Sun Aug 2 19:16:04 CEST 2009


2009/8/2 M?ns Rullg?rd <mans at mansr.com>:
> ?smail D?nmez <ismail at namtrac.org> writes:
>
>> Hi,
>>
>> On Sun, Aug 2, 2009 at 7:39 PM, Diego Biurrun<diego at biurrun.de> wrote:
>>> On Sun, Aug 02, 2009 at 07:35:49PM +0300, ?smail D?nmez wrote:
>>>>
>>>> Patch attached.
>>>>
>>>> --- libavformat/os_support.h ?(revision 19560)
>>>> +++ libavformat/os_support.h ?(working copy)
>>>> @@ -34,6 +34,11 @@
>>>> ?# ?define lseek(f,p,w) _lseeki64((f), (p), (w))
>>>> ?#endif
>>>>
>>>> +#if defined(__MINGW32CE__)
>>>> +# ?define getenv(x) ""
>>>> +# ?define strerror(x) ""
>>>> +#endif
>>>
>>> I think you could merge this with the section above and simplify both.
>>> Also, IIRC the "" are unnecessary.
>>
>> New patch attached. It doesn't work without the "" part.
>
> getenv() should be NULL, not an empty string.

Attached version returns NULL for getenv() and "N/A" for strerror() so
it should be better.

Regards.

-- 
?smail D?NMEZ
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wince-nop.patch
Type: application/octet-stream
Size: 476 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090802/4497c21f/attachment.obj>



More information about the ffmpeg-devel mailing list