[FFmpeg-devel] LPCM for mpeg-ts
Christian P. Schmidt
Mon Aug 3 09:40:12 CEST 2009
Diego Biurrun wrote:
> Here and in other places you could easily break overly long lines.
Please define overly long, in a number. I think 120-130 is ok since we
left the 1990s.
>> + if (pcm_bluray_parse_header (avctx, src))
>> + return -1;
Done. Any ideas how to tell emacs to use indent of 4 in a certain
>> +#ifdef WORDS_BIGENDIAN
> This is non-existing and should have caused a warning, which you must
> have ignored.
You could just have said "we changed that recently, update your
checkout". It compiled without warnings for me. Fixed.
> Your patch is missing documentation, changelog and Makefile updates.
--- ffmpeg.old/trunk/libavcodec/Makefile 2009-07-14 15:53:07.430807476 +0300
+++ ffmpeg/trunk/libavcodec/Makefile 2009-07-30 11:40:44.434824715 +0300
@@ -278,6 +278,7 @@
# (AD)PCM decoders/encoders
OBJS-$(CONFIG_PCM_ALAW_DECODER) += pcm.o
OBJS-$(CONFIG_PCM_ALAW_ENCODER) += pcm.o
+OBJS-$(CONFIG_PCM_BLURAY_DECODER) += pcm-mpeg.o
OBJS-$(CONFIG_PCM_DVD_DECODER) += pcm.o
OBJS-$(CONFIG_PCM_DVD_ENCODER) += pcm.o
OBJS-$(CONFIG_PCM_F32BE_DECODER) += pcm.o
Which other Makefile needs updates?
For the changelog: You mean a line in the actual Changelog file? Done.
For the documentation: more inline for doxygen, or is external required?
I added more doxygen comments.
I hope the attached path gets us closer to resolution.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the ffmpeg-devel