[FFmpeg-devel] [PATCH] ffmpeg.c : replace perror() by av_log

Michael Niedermayer michaelni
Mon Aug 3 13:28:28 CEST 2009


On Sun, Aug 02, 2009 at 08:39:19PM +0300, ?smail D?nmez wrote:
> Hi,
> 
> 2009/8/2 M?ns Rullg?rd <mans at mansr.com>:
> >> Index: ffmpeg.c
> >> ===================================================================
> >> --- ffmpeg.c ?(revision 19566)
> >> +++ ffmpeg.c ?(working copy)
> >> @@ -1085,7 +1085,7 @@
> >> ? ? ?if (!vstats_file) {
> >> ? ? ? ? ?vstats_file = fopen(vstats_filename, "w");
> >> ? ? ? ? ?if (!vstats_file) {
> >> - ? ? ? ? ? ?perror("fopen");
> >> + ? ? ? ? ? ?av_log(NULL, AV_LOG_ERROR, "Failed to open stats file: %s\n", strerror(errno));
> >
> > Maybe it would be nice to print the failing filename too while at it.
> 
> New patch attached.

Could you first explain the "why" part behind this patch?
i mean what does it fix or improve?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090803/14b7ecb8/attachment.pgp>



More information about the ffmpeg-devel mailing list