[FFmpeg-devel] [PATCH] Playlist API

Diego Biurrun diego
Fri Aug 7 00:30:05 CEST 2009

On Thu, Aug 06, 2009 at 12:35:35PM -0700, Geza Kovacs wrote:
> This updated patch implements seeking over the entire playlist. As I
> stated in my previous message, the API is able to handle playlist items
> with differing numbers of streams.

Please find all the opportunities to prettyprint your code yourself.
You could also be a tad more generous with whitespace around operators
and sometimes break some long lines.

> diff --git a/libavformat/Makefile b/libavformat/Makefile
> index 7838efe..2377365 100644
> --- a/libavformat/Makefile
> +++ b/libavformat/Makefile
> @@ -33,6 +33,7 @@ OBJS-$(CONFIG_BETHSOFTVID_DEMUXER)       += bethsoftvid.o
>  OBJS-$(CONFIG_CAVSVIDEO_DEMUXER)         += raw.o
> +OBJS-$(CONFIG_CONCAT_DEMUXER)            += m3u.o pls.o xspf.o playlist.o concat.o concatgen.o

The other demuxers cannot be compiled standalone?  This smells of
insufficient separation.

Some of the #ifdefs in your files are probably unnecessary.

This is missing Changelog and documentation updates.


More information about the ffmpeg-devel mailing list