[FFmpeg-devel] [PATCH][RFC] Lagarith Decoder.

Diego Biurrun diego
Fri Aug 7 00:38:03 CEST 2009


On Thu, Aug 06, 2009 at 03:06:32PM -0600, Nathan Caldwell wrote:
> Here's my first attempt at a Lagarith decoder. At the moment it only
> handles YV12 content, I do plan on adding in the other modes (RGB24,
> YUY2, and RGBA). I just wanted some input on things that need changed
> before I get too far along.

Good idea.

Documentation and build system parts are OK.

There are plenty of opportunities for vertical alignment, use them :)

> --- /dev/null
> +++ libavcodec/lagarith.c
> @@ -0,0 +1,574 @@
> +
> +typedef struct LagarithContext{

nit: space before {

> +    for( i=0 ; !( prevbit && bit ); i++)
> +    {
> +    if (bits == 0) return 0;

Please consistently use K&R coding style, i.e.

  for (i = 0; !(prevbit && bit); i++) {

  if (!bits)
      return 0;

same in other places

Diego



More information about the ffmpeg-devel mailing list