[FFmpeg-devel] [PATCH] Drop unneeded YUV2RGB funcs

Kostya kostya.shishkov
Fri Aug 7 08:34:35 CEST 2009


On Wed, Aug 05, 2009 at 01:39:49PM +0200, Michael Niedermayer wrote:
> On Wed, Aug 05, 2009 at 08:51:56AM +0300, Kostya wrote:
> > On Tue, Aug 04, 2009 at 10:46:57PM -0700, Mike Melanson wrote:
> > > Kostya wrote:
> > >> $subj, their functionality is duplicated in YSCALE_YUV_2_ANYRGB_*
> > >> Also that fixes bug with swapping pixels on odd lines.
> > >
> > > Forgot patch.
> > 
> > Am I a FFmpeg dev or not?
> 
> no, a real ffmpeg dev would have included benchmarks from several different
> architectures when he proposes droping some optimized code he wrote that
> contains a bug that he doesnt want to fix.

s/doesnt want/is too lazy/

> Yes sure we have a fallback but that may be slower, of course it doesnt
> have to be slower but as said that has to be checked before droping this
> code.

I've run "time swscale-example", its execution time seems to increase by
several percents, so here's proper patch.

> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
-------------- next part --------------
A non-text attachment was scrubbed...
Name: swscale-yuv2rgb.patch
Type: text/x-diff
Size: 6577 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090807/896894fa/attachment.patch>



More information about the ffmpeg-devel mailing list