[FFmpeg-devel] [PATCH] Misc. tag handling related patches

Kostya kostya.shishkov
Sun Aug 9 16:59:06 CEST 2009

On Sun, Aug 09, 2009 at 11:43:48AM +0300, Matti Hamalainen wrote:
> A bunch of patches mostly related to improving APE tag handling.
> Included fixes are based on my own tests and Hydrogenaudio's wiki-page
> http://wiki.hydrogenaudio.org/index.php?title=APEv2_specification
> Most of these need to be applied in (following) order:
> 1) fix-ape-tag-size-adjustment.patch
> Remove incorrect tag size adjustment based on flags, the size already
> includes the whole tag, including footer.
> 2) fix-ape-tag-key-handling.patch
> Fix broken APE tag key handling and use get_byte instead of dangerously
> fiddling with the ByteIOContext buffer directly without bounds checking.
> Also add return value to ape_tag_read_field() and break on reading further
> tag fields if one fails.
> 3) improve-ape-tag-handling.patch
> Try to handle different placements of APE tags better, including those 
> placed at file beginning.
> 4) separate-ape-tag-handling.patch
> This is a big one, and adds two new files:
> Move APE tag handling to apetag.[ch] and add ff_-prefix to 
> ape_parse_tag().
> 5) musepack-sv7-ape-tag-support.patch
> Add APE tag metadata reading support in Musepack SV7 demuxer.
> 6) musepack-sv7-id3v2-tag-support.patch
> Add parsing of ID3v2 tags in Musepack SV7 demuxer.
> (This does not actually depend on previous patches.)

Ahem, I can't review that bunch especially since patches are attached in
wrong order. Please resend them properly (i.e. "[PATCH 3/6] Improve APE
tag handling").

Also you seem to add a lot of random empty lines.

More information about the ffmpeg-devel mailing list