[FFmpeg-devel] [PATCH]Fix bug caused by difference in stride and picture width in libschroedingerenc and libschroedingerdec

Diego Biurrun diego
Mon Aug 10 14:42:38 CEST 2009


On Mon, Aug 10, 2009 at 12:34:42PM +1000, Anuradha Suraparaju wrote:
> 
> The patch if for svn revision 19610.
> 
> --- libavcodec/libschroedinger.c	(revision 19610)
> +++ libavcodec/libschroedinger.c	(working copy)
> @@ -78,3 +78,57 @@
> +
> +static void FreeSchroFrame(SchroFrame *frame, void *priv)
> +{
> +    AVPicture *p_pic = priv;
> +
> +    if (!p_pic) {
> +        return;
> +    }

useless {}

> +SchroFrame *ff_create_schro_frame (AVCodecContext *avccontext,
> +                                   SchroFrameFormat schro_frame_fmt)

Please use standard K&R style, i.e. no space after function names.  You
are wildly inconsistent.

> +    for (i=0; i<3; ++i) {

Spaces around operators would help readability here.

> +        if (i != 0) {

if (i) {

> --- libavcodec/libschroedinger.h	(revision 19610)
> +++ libavcodec/libschroedinger.h	(working copy)
> @@ -57,5 +57,12 @@
>  
> +SchroFrame *ff_create_schro_frame (AVCodecContext *avccontext,
> +                                   SchroFrameFormat schro_frame_fmt);

see above

more instances below

Diego



More information about the ffmpeg-devel mailing list