[FFmpeg-devel] [PATCH] remove disabled code part 4

Diego Biurrun diego
Mon Aug 10 15:51:13 CEST 2009


On Mon, Aug 10, 2009 at 03:24:11PM +0200, Michael Niedermayer wrote:
> On Mon, Aug 10, 2009 at 03:00:09PM +0200, Diego Biurrun wrote:
> > On Fri, Aug 07, 2009 at 11:15:19AM +0200, Diego Biurrun wrote:
> > > I started looking into disabled code, there is lots of it and probably
> > > mostly cruft.  Here is a patch that removes it, starting at the top
> > > level and the tests subdirectory.  More patches shall follow later.
> > > 
> > > I will commit approved hunks only.
> > 
> > .. libavutil ..
> > 
> > --- libavutil/bswap.h	(revision 19614)
> > +++ libavutil/bswap.h	(working copy)
> > @@ -60,11 +60,6 @@
> >  #ifndef bswap_64
> >  static inline uint64_t av_const bswap_64(uint64_t x)
> >  {
> > -#if 0
> > -    x= ((x<< 8)&0xFF00FF00FF00FF00ULL) | ((x>> 8)&0x00FF00FF00FF00FFULL);
> > -    x= ((x<<16)&0xFFFF0000FFFF0000ULL) | ((x>>16)&0x0000FFFF0000FFFFULL);
> > -    return (x>>32) | (x<<32);
> > -#else
> 
> can be removed if slower on all major archs

benchmarking hints?

> > --- libavutil/lls.c	(revision 19614)
> > +++ libavutil/lls.c	(working copy)
> > @@ -118,20 +118,10 @@
> >      for(i=0; i<100; i++){
> >          double var[4];
> >          double eval;
> > -#if 0
> > -        var[1] = rand() / (double)RAND_MAX;
> > -        var[2] = rand() / (double)RAND_MAX;
> > -        var[3] = rand() / (double)RAND_MAX;
> > -
> > -        var[2]= var[1] + var[3]/2;
> > -
> > -        var[0] = var[1] + var[2] + var[3] +  var[1]*var[2]/100;
> > -#else
> >          var[0] = (rand() / (double)RAND_MAX - 0.5)*2;
> >          var[1] = var[0] + rand() / (double)RAND_MAX - 0.5;
> >          var[2] = var[1] + rand() / (double)RAND_MAX - 0.5;
> >          var[3] = var[2] + rand() / (double)RAND_MAX - 0.5;
> > -#endif
> >          av_update_lls(&m, var, 0.99);
> >          av_solve_lls(&m, 0.001, 0);
> >          for(order=0; order<3; order++){
> 
> ok

Removed.

Diego



More information about the ffmpeg-devel mailing list