[FFmpeg-devel] [PATCH] 2/6 Fix broken APE tag key handling
Tue Aug 11 18:55:58 CEST 2009
On Mon, Aug 10, 2009 at 09:49:52PM +0300, Matti Hamalainen wrote:
> On Mon, 10 Aug 2009, Kostya wrote:
> > > size = get_le32(pb); /* field size */
> > > - url_fskip(pb, 4); /* skip field flags */
> > > -
> > > - for (i=0; pb->buf_ptr[i]!='0' && pb->buf_ptr[i]>=0x20 && pb->buf_ptr[i]<=0x7E; i++);
> > Ahem, is this buf_ptr[i]!='0' an error by original author or you just
> > forgot to check for it?
> Probably meant to be '\0' by original author. The allowed characters in
> APE tag field keys are 0x20 through 0x7e (see the Hydrogenaudio docs).
> Thus I think checking for < 0x20 && > 0x7e is sufficient.
MAC code agrees, applied.
More information about the ffmpeg-devel