[FFmpeg-devel] [PATCH][RFC] Lagarith Decoder.

Michael Niedermayer michaelni
Wed Aug 12 20:55:02 CEST 2009


On Wed, Aug 12, 2009 at 08:42:23PM +0200, Reimar D?ffinger wrote:
> On Wed, Aug 12, 2009 at 06:59:42PM +0100, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > On Wed, Aug 12, 2009 at 06:31:36PM +0200, Reimar D?ffinger wrote:
> > >> On Wed, Aug 12, 2009 at 05:10:36PM +0100, M?ns Rullg?rd wrote:
> > >> > Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > >> > 
> > >> > > On Wed, Aug 12, 2009 at 04:12:25PM +0100, M?ns Rullg?rd wrote:
> > >> > >> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > >> > >> 
> > >> > >> > Well, you still have to teach the compiler at least to use clz for
> > >> > >> > av_log2, I think you haven't yet ;-)
> > >> > >> 
> > >> > >> I can't because it's in common.h, which is installed.  We really
> > >> > >> should find a way to fix that.
> > >> > >
> > >> > > Just put the optimizations under HAVE_AV_CONFIG_H like everything else
> > >> > > in there that is messy?
> > >> > 
> > >> > And keep adding to the mess?  That's not the way to do things.
> > >> 
> > >> Then how about adding a new internal header with that function and
> > >> putting the version in the installed header under
> > >> #ifndef HAVE_AV_CONFIG_H
> > >> i.e. just to keep API compatibility?
> > >> Possibly even deprecating that version?
> > >> Would that be clean enough?
> > >
> > > It would be nice if applications using libav* could also use the optimized
> > > version
> > 
> > I can't see a way to make that happen.
> 
> Actually... You could install a pseudo-config.h that contains the
> necessary CPU settings...
> There is not really a reason we can't install generated headers...

> Or am I missing something?

I said ages ago alraedy that "config.h" should be installed :)


> Except maybe we should make clear that stuff in that header should not
> be considered part of the public API.

*config.h shouldnt be public API, yes. At least at the start, later parts
of it might actually be useull to some applications and we might consider
making them public API, but thats for a future discussion its just not
relevant now given we dont install any such header ...


> And the defines should have less generic names than HAVE_* and CONFIG_*

of course

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090812/f8905ab9/attachment.pgp>



More information about the ffmpeg-devel mailing list