[FFmpeg-devel] [PATCH] dvdsubdec make pos values unsigned

[Michael Niedermayer]

On Thu, Aug 13, 2009 at 01:31:01PM +0200, Reimar D?ffinger wrote:
> On Thu, Aug 13, 2009 at 01:25:20PM +0200, Reimar D?ffinger wrote:
> > Hello,
> > dvdsubdec reads 32 bit values into e.g. cmd_pos and then checks its
> > validity with e.g.
> > while ((cmd_pos + 2 + offset_size) < buf_size) {
> > which obviously is not correct.
> > I suggest the simplest fix of making these variables unsigned:
> 
> Forget that, that's almost as wrong.
> This one I think works and is sufficient:

ok
do you maybe want to become maintainer of dvdsubdec ? 

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090814/343aeb8e/attachment.pgp>