[FFmpeg-devel] IEC61937 compatible muxer
Tue Aug 18 01:31:58 CEST 2009
On Mon, Aug 17, 2009 at 11:25:56AM +0200, Bartlomiej Wolowiec wrote:
> Monday 17 August 2009 02:43:53 Michael Niedermayer napisa?(a):
> > > + int pkt_offset; ///< Repetition period of data burst
> > > in bytes
> > is it just me or is the doxy unclear?
> it's like number of bytes between two next data bursts (packets, which have
> header and burst payload (encapsuled frame)). Should i change comments, or
> maybe add at begining of file some explanation of terminology?
i guess both are a good idea
> > > + uint8_t *buffer; ///< Allocated buffer, used for swap
> > > bytes + int buffer_size; ///< Size of allocated buffer
> > >
> > >
> > > + /// Function, which generates codec dependent header information
> > > + int (*header_info) (AVFormatContext *s, AVPacket *pkt);
> > this too is a little unclear
> > also i would add a empty line before /// ...
> > > +} IEC958Context;
> > > +
> > >
> > > +//TODO move to DSP
> > please do, we alraedy have bswap_buf there
> i thought about it, but there is one little problem - dsputil_init() gets
> pointer to AVCodecContext... Any idea how should i use it in libavformat ?
i have a few
dsputil could be split into a AVCodecContext specific context and a non
specific one, the later could be shared amongth all "users".
though i guess that could be done after the patch is commited
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel