[FFmpeg-devel] [PATCH] Decoding of raw UTF-8 text from Ogg streams
Tue Aug 18 14:35:07 CEST 2009
On Tue, Aug 18, 2009 at 12:43:39PM +0100, ogg.k.ogg.k at googlemail.com wrote:
> > this silent error handling seems bad to me
> > if start is always 0 it doesnt need to be passed into the function to begin
> > with
> Done. Also changed the function name to match, and added a comment
> as to why the start time is ignored.
thats a misunderstanding, the code set
*start=0 always and explicitly thus there is no point in passing int *start
into the function
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel