[FFmpeg-devel] [PATCH] remove disabled code part 1
Tue Aug 18 22:22:05 CEST 2009
On Tue, Aug 18, 2009 at 03:20:55PM +0200, Diego Biurrun wrote:
> On Mon, Aug 10, 2009 at 02:56:49PM +0200, Diego Biurrun wrote:
> > On Fri, Aug 07, 2009 at 02:23:45PM +0200, Michael Niedermayer wrote:
> > > On Fri, Aug 07, 2009 at 11:15:19AM +0200, Diego Biurrun wrote:
> > > > I started looking into disabled code, there is lots of it and probably
> > > > mostly cruft. Here is a patch that removes it, starting at the top
> > > > level and the tests subdirectory. More patches shall follow later.
> > > >
> > > > I will commit approved hunks only.
> > >
> > > remaining hunks i didnt comment on are "dont know what it does exactly / not
> > > sure if usefull"
> > The stuff from ffplay.c originates from the first revision of ffplay and
> > has never been enabled. Is this proof enough that it is cruft and
> > should be removed?
> .. ping ..
no, its not proof that its cruft and should be removed.
Maybe it is cruft but age is no proof, I just like to understand what that
code did before its droped ...
If you or someone else can guess what it could have been good for? then we
can make a decission based on that but i dont like throwing unopened boxes
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel