[FFmpeg-devel] [PATCH] Fix unaligned fill_rectangle in rv34.c

Kostya kostya.shishkov
Thu Aug 20 09:33:19 CEST 2009


On Thu, Aug 20, 2009 at 09:14:54AM +0200, Reimar D?ffinger wrote:
> Hello,
> rv34.c uses fill_rectangle with only 4 bytes alignment, which causes
> crashes on 64 bit architectures without unaligned read support like
> Sparc/Solaris.
> This patch hacks rectangle.h to support this kind of use - this
> seemed the simplest, even though rather hackish, way to me.

May I add that it happens when zeroing motion vectors for some
macroblock, i.e. where there will be non-64bit align for sure.

Probably better solution would be to disable this code automatically for
such archs. I don't remember an outcome of my discussion with Mans
about that though.



More information about the ffmpeg-devel mailing list