[FFmpeg-devel] IEC61937 compatible muxer

Bartlomiej Wolowiec bartek.wolowiec
Fri Aug 21 10:36:56 CEST 2009


Wednesday 19 August 2009 12:08:10 Michael Niedermayer napisa?(a):
> On Wed, Aug 19, 2009 at 10:59:04AM +0200, Bartlomiej Wolowiec wrote:
> > Tuesday 18 August 2009 14:20:04 Michael Niedermayer napisa?(a):
> > > >  Changelog                |    1
> > > >  doc/general.texi         |    1
> > > >  libavformat/Makefile     |    1
> > > >  libavformat/allformats.c |    1
> > > >  libavformat/avformat.h   |    2
> > > >  libavformat/spdif.c      |  310
> > > > +++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 315
> > > > insertions(+), 1 deletion(-)
> > > > 5e1050033d862e1e5adcfc1cb8019129cc27a1cf  patch
> > >
> > > looks ok to me, given it works, has been tested and you add regression
> > > tests
> > >
> > > [...]
> >
> > I made some corrections suggested by Diego.
> > Yes, this code is working (not all MPEG options are tested, but they
> > should work), so should i commit this patch and make next commit with
> > regression tests or commit all at once ?
>
> iam slightly in favor of 2 commits but thats very very slightly only
>
> [...]

Hi,
Patch applied.
I thought about regression tests and I don't know what should i exactly do...
Should there be used FFmpegs encoders (ac3, mp3...) to make right audio format 
and then save with spdif format or something else?
-- 
Bartlomiej Wolowiec



More information about the ffmpeg-devel mailing list