[FFmpeg-devel] [PATCH 4/6] asfdec: convert variable-length array to fixed size

Måns Rullgård mans
Sat Aug 22 17:03:25 CEST 2009


Michael Niedermayer <michaelni at gmx.at> writes:

> ssOn Wed, Aug 19, 2009 at 02:23:00AM +0100, Mans Rullgard wrote:
>> MAX_STREAMS is small enough that it doesn't matter
>> ---
>>  libavformat/asfdec.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> we wanted to get rid of MAX_STREAMS limits thus this one would be just
> moving more work on the poor guy who actually tries to get rid of it

Good point, but then we should still do something else with this,
since if that limit goes away, this would be requesting an unbounded
amount of stack space, which is not a good idea.  Is malloc/free
acceptable in this function?

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list