[FFmpeg-devel] [PATCH] ALS decoder

Michael Niedermayer michaelni
Sun Aug 23 05:41:34 CEST 2009


On Sun, Aug 23, 2009 at 12:47:49AM +0200, Herv? W. wrote:
> Comments are inline. (My use of "perhaps" is not sarcasm or something).
> 
> 2009/8/22 Thilo Borgmann <thilo.borgmann at googlemail.com>:
[...]
> >>> + ? ?int aux_data_enabled; ? ? ///< indicates that auxiliary data is present
> >>
> >>> + ? ?int chan_config_info; ? ? ///< mapping of channels to loudspeaker locations
> >>
> >> never read
> > But a TODO is set to use it in a future release.
> 
> I think the guideline is: don't add it until you need it.
> Unless you can guarantee that you'll be around to implement that TODO.

or add a "unused currently will be used once foobar is implemenetd"

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090823/6af66b39/attachment.pgp>



More information about the ffmpeg-devel mailing list