[FFmpeg-devel] [PATCH] ALS decoder
Sun Aug 23 19:24:29 CEST 2009
>> If we assume a non-broken stream, I think using 32-bit math would be safe.
> if i understand you correctly, the code (or some of it) does not need 64bit?
> if so it should use 32bit. Detecting broken streams/frames is something nice
> that we can think of later unless the values are used in some security relevant
> context like in indexing arrays or the size of allocated things.
I agree. The reference decoder uses the 64-bit domain to detect
overflows in adding 32-bit values - if overflow, stop decoding. Thus, it
is a failure detection. And, if we assume non-broken streams, I think
this does not occur.
Revision 6 already uses 32-bit for that.
More information about the ffmpeg-devel