[FFmpeg-devel] [PATCH] First shot at AVCHD seeking via new seeking API
Wed Aug 26 08:52:40 CEST 2009
Hi Michael & Baptiste,
Michael Niedermayer wrote:
> On Tue, Aug 25, 2009 at 02:25:57PM -0700, Baptiste Coudurier wrote:
>> On 08/22/2009 09:10 AM, Ivan Schreter wrote:
>>> Ivan Schreter wrote:
>>>> I think it's clean and 100% exact now.
>>> Since noone objected to the newest patch, I've committed it today.
>>> AVCHD/MPEG-TS now properly supports new seeking API.
>>> As for MPEG-PS, there is still one issue, which has to be resolved
>>> (different thread in ML).
>> I'm sorry but this is unacceptable. I don't recall the patch being
>> approved, furthermore there are still comments pending.
>> Furthermore the patch contains useless casts and the state saving and
>> restoring part was not reviewed at all.
>> Please revert the patch for now.
> i didnt want to say it without reviewing the actually commited code,
> (for which i didnt yet had time) but i too felt this should be reverted
> and reviewed first.
Actually, since I did address all the comments either by changing the
code according to them (most) or argumenting why it is needed to do it
that way (one or two), I didn't feel there are open points. I didn't get
any comments on state saving/restore. Since I didn't hear from Baptiste
for a month, I assumed, he is OK with the changes made (as per FFmpeg
development policy point #11).
The comments from Michael regarding timestamp handling have been
integrated as well in the code.
So what are the open points in your opinion? What still needs to be
reviewed? Possibly the state saving/restore, but otherwise I think the
whole stuff was reviewed sufficiently. BTW, what useless casts did you mean?
Since the new seeking code is completely contained separately of format
handlers, I propose instead of the full revert the following: I'll put
an #ifdef in mpegts.c, which disables the new seeking and uses the old
stuff per default (as per FFmpeg development policy point #2). I can do
it today evening. What do you think?
Thanks & regards,
More information about the ffmpeg-devel