[FFmpeg-devel] [PATCH] Fix unaligned fill_rectangle in rv34.c

Kostya kostya.shishkov
Fri Aug 28 07:29:08 CEST 2009

On Thu, Aug 27, 2009 at 09:57:56PM +0200, Reimar D?ffinger wrote:
> On Sat, Aug 22, 2009 at 04:11:19PM +0200, Michael Niedermayer wrote:
> > let me try again
> > if you write a rectangle of 8xC then there exists a semantic partitioning
> > of sizeof=8, and things could be aligned accordingly, if not you cannot
> > use fill_rectangle()
> > you would have to replace r->avail_cache + 5 by + 6 maybe and make other
> > related changes, its perfectly fine as well if you dont and remove all
> > calls to fill_rectangle() from your code but fill_rectangle() requires
> > aligned memory.
> So can we get over with this and use attached patch?
> The important cases needs something far simpler than fill_rectangle,
> so it is not that bad code-wise I think.

I'm not against it but Michael may complain since this function may be
useful for other pieces of code it should be put into some header.

More information about the ffmpeg-devel mailing list