[FFmpeg-devel] [PATCH] remove disabled code part 1

Christian P. Schmidt schmidt
Sat Aug 29 11:46:20 CEST 2009


Diego Biurrun wrote:
> On Fri, Aug 07, 2009 at 11:15:19AM +0200, Diego Biurrun wrote:
>> I started looking into disabled code, there is lots of it and probably
>> mostly cruft.  Here is a patch that removes it, starting at the top
>> level and the tests subdirectory.  More patches shall follow later.
>>
>> I will commit approved hunks only.
> 
> libavdevice..

[...]
> Index: libavdevice/v4l.c
> ===================================================================
> --- libavdevice/v4l.c	(revision 19725)
> +++ libavdevice/v4l.c	(working copy)
> @@ -148,14 +148,6 @@
>      ioctl(video_fd, VIDIOCSAUDIO, &audio);
>  
>      ioctl(video_fd, VIDIOCGPICT, &pict);
> -#if 0
> -    printf("v4l: colour=%d hue=%d brightness=%d constrast=%d whiteness=%d\n",
> -           pict.colour,
> -           pict.hue,
> -           pict.brightness,
> -           pict.contrast,
> -           pict.whiteness);
> -#endif
>      /* try to choose a suitable video format */
>      pict.palette = desired_palette;
>      pict.depth= desired_depth;

[...]

Maybe

    if (s1->debug & FF_DEBUG_PICT_INFO)
        dprintf(s1, "v4l: colour=%d ...

instead of removing? Looks like typical debug info to me that could even
be useful.

Regards,
Christian



More information about the ffmpeg-devel mailing list