[FFmpeg-devel] [PATCH] Fix unaligned fill_rectangle in rv34.c
Sat Aug 29 14:50:38 CEST 2009
On Sat, Aug 29, 2009 at 01:59:13PM +0200, Michael Niedermayer wrote:
> well, you could really try to change stride or call
> fill_rectangle twice with half the size? not ideal but neither is
> a custom functiondoing misaligned access
misaligned access for 64 bit systems. IMHO you are trying to optimize for
64 bit systems with questionable benefit even on those and to the
disadvantage of 32 bit systems and more complex code.
I admit it all should be benchmarked, thanks to the write optimizations
in modern CPU all those optimizations could even be vastly slower (e.g.
if your wrote as 32 bit and the directly after read as 16 bit variables
that can cause quite a slowdown - not that it seems to be the case here).
More information about the ffmpeg-devel