[FFmpeg-devel] [PATCH] Add a slice_dir parameter to avfilter_start_frame()

Michael Niedermayer michaelni
Wed Dec 2 03:08:37 CET 2009

On Wed, Dec 02, 2009 at 01:39:43AM +0100, Stefano Sabatini wrote:
> Hi,
> this is useful for the scale, slicify and pad filters, which have
> otherwise to heuristically determine the slice direction, so
> duplicating code.
> Also I'm not sure about which values to use for the slice_dir, now I'm
> using 1/-1 but >0/<0 may be better, suggestions?


> -void avfilter_start_frame(AVFilterLink *link, AVFilterPicRef *picref)
> +void avfilter_start_frame(AVFilterLink *link, AVFilterPicRef *picref, int slice_dir)

i suggested draw_slice()
we need it only in draw_slice()
your code now must store it always in the context because its never needed
in start_frame but always in draw_slice()
you dont even attempt to explain why you do it like that and not like i
YOu didnt expect me to do anything except rejecting this did you?
its more complex and its completely unclear why its done like that

If you do something different, please explain why you do it differently
i cant read your mind ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091202/6a39bbc1/attachment.pgp>

More information about the ffmpeg-devel mailing list