[FFmpeg-devel] [BUG, PATCH] Revert broken use of ff_put_string() in vorbis_enc.c

Reimar Döffinger Reimar.Doeffinger
Wed Dec 2 21:37:07 CET 2009

On Sat, Nov 28, 2009 at 06:52:19PM +0100, Philipp Matthias Hahn wrote:
> Revert commit 20095: Don't use ff_put_string in vorbis encoder.
> ff_put_string() is declared in bistream.c, which uses put_bits() without
> BITSTREAM_WRITER_LE being defined.
> vorbis_enc.c on the other hand #defines BITSTREAM_WRITER_LE and thus must not
> use this function.

Please #define ff_put_string away in put_bits.h (similarly as for printf, ...)
for the LE case so this can not happen again (and then you do not need that
large comment anymore).

More information about the ffmpeg-devel mailing list