[FFmpeg-devel] [PATCH 5/6] RTMP output: implement rtmp-output
Fri Dec 4 17:37:05 CET 2009
On Fri, Dec 04, 2009 at 06:26:47PM +0200, Sergiy wrote:
> 2009/12/4 Kostya <kostya.shishkov at gmail.com>:
> > braces, please (in all such places)
> > obviously
> > ?if(!t && !strcmp("NetStream.Play.Start")) rt->state = STATE_PLAYING;
> > ?if(!t && !strcmp("NetStream.Publish.Start")) rt->state =
> > STATE_PUBLISHING;
> > what you did is semantically wrong
> "return 0" removed too, because rtmp_parse_result() returns 0.
> > Again, this seems like unneeded condition. Probably you just forget to
> > send rt->flv_data = NULL along with rt->flv_size = 0.
> But setting rt->flv_size to 0 is not necessary.
Looks ok, send cosmetics and I'll apply it.
More information about the ffmpeg-devel