[FFmpeg-devel] [PATCH] libavcodec interface to no_mbtree option of libx264

Erik Slagter erik
Sun Dec 6 14:33:38 CET 2009

> > +#define CODEC_FLAG2_NO_MBTREE 0x00040000 ///< Do not use macroblock tree ratecontrol (x264 only)
> I don't think flags shouldn't never be negative.

Do you mean by this that bits beyond 17 shouldn't be used at all? I
don't see the "magic" of 17 here? This one apparently is OK:
#define CODEC_FLAG_INTERLACED_DCT 0x00040000 ///< Use interlaced DCT.
I assumed there is no 0x00040000 objection agains using this number?

Or do you want the semantics to be reversed? Like a MBTREE flag instead
of NO_MBTREE? I guess it should be initialised to true then...

More information about the ffmpeg-devel mailing list