[FFmpeg-devel] Problem with initial dts in h264

[Carl Eugen Hoyos]

Hi!

Michael Niedermayer <michaelni <at> gmx.at> writes:

> > --- libavformat/utils.c	(revision 20757)
> > +++ libavformat/utils.c	(working copy)
> > @@ -1177,7 +1177,7 @@
> >  void av_read_frame_flush(AVFormatContext *s)
> >  {
> >      AVStream *st;
> > -    int i;
> > +    int i, j;
> >  
> >      flush_packet_queue(s);
> >  
> > @@ -1200,6 +1200,9 @@
> >          st->cur_len = 0;
> >  
> >          st->probe_packets = MAX_PROBE_PACKETS;
> > +
> > +        for(j=0; j<MAX_REORDER_DELAY+1; j++)
> > +            st->pts_buffer[j]= AV_NOPTS_VALUE;
> >      }
> >  }
> >  
> 
> 2 hunks above ok (if tested), (and maybe with FF_ARRAY_ELEMS())

I believe you over-estimate the number of people on this list who are
a) able to understand what they should test before applying this and
b) apply other people's patches at all.

I will happily apply both hunks if you want (and I think we will find out soon
if they do any harm), but I have no idea what to test.

Carl Eugen

PS: Could you look at the regression issue 1550 (sample in incoming/issue1550)?
And could one of the H264 experts look at issue 1585? I suspect an important
issue, but maybe it is just a broken sample.