[FFmpeg-devel] [PATCH] Add pad filter

Michael Niedermayer michaelni
Sat Dec 12 18:43:00 CET 2009

On Sat, Dec 12, 2009 at 03:14:40PM +0100, Stefano Sabatini wrote:
> On date Tuesday 2009-12-08 13:42:01 +0100, Stefano Sabatini encoded:
> > On date Tuesday 2009-12-08 03:01:04 +0100, Michael Niedermayer encoded:
> > > but i think there might be another problem that will need fixing,
> > > are data[x] aligned to 16 bytes? because some optimized filters will
> > > need them aligned and id guess pad & crop can produce non aligned cases.
> > > so possibly we need a AV_PERM_ALIGNED that ensures maximum alignment the
> > > cpu might need initiating a copy of the frame if its insfficiently aligned.
> Ping+patch for the pad filter updated.

read above, there is a problem in the pad and crop filters.

Besides this, we need regression tests for the filters, i plan to make
this mandatory for every new filter now, too many bugs sliped through
No reg test for a filter -> no approval.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091212/71820bf7/attachment.pgp>

More information about the ffmpeg-devel mailing list