[FFmpeg-devel] [PATCH][RFC] add a list of generic tag names

Anton Khirnov wyskas
Mon Dec 14 22:12:57 CET 2009

On Mon, Dec 14, 2009 at 09:18:48PM +0100, Michael Niedermayer wrote:
> does it work otherwise? if not it was necessary (thats pretty much the
> definition of necessary)
i meant why did you change author to artist yesterday? it breaks apps
that expect to find 'author' and i don't see any real advantage.
> why can AlbumArtist be remove but genre need an entry?
indeed. removed along with 'copyright'.
> is NULL or is not NULL ?
i think the comment is correct -- if both tables != NULL we're
converting from/to something else than generic format.
> This text probably belongs closer to:
> /*
>  * Public Metadata API.

Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-a-list-of-generic-tags.patch
Type: text/x-diff
Size: 11625 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091214/741431b2/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091214/741431b2/attachment.pgp>

More information about the ffmpeg-devel mailing list