[FFmpeg-devel] [Toy] Xxan (aka Xan for WC4) decoder

Kostya kostya.shishkov
Fri Dec 18 16:28:54 CET 2009


On Fri, Dec 18, 2009 at 03:51:37PM +0100, Diego Biurrun wrote:
> On Thu, Dec 17, 2009 at 03:15:31PM +0200, Kostya wrote:
> > Well, $subj. Now it plays files almost fine.
> > Mike should have finished it long time ago though.
> 
> How does this differ from the xan.c we already have, i.e. why is it
> not a patch?

Hard to say, they are both based on Mike's work and I just hacked it a
bit to make it work (same with Interplay Video 16-bit decoder), hence
the tag "toy" and not "patch". It needs lot of things to be cleaned
before commit anyway.

Also the base code is so old that it does not conform to current
standards anyway (look into current version for numerous examples).

[...]
> >         return;
> > {
> > static int frame = 0;
> > av_log(NULL,0,"Frame %d(%d) - %d, %X %X %X\n",++frame,AV_RL32(s->buf),AV_RL32(s->buf+4),AV_RL16(s->buf + AV_RL32(&s->buf[4]) + 4),AV_RL32(s->buf+8),AV_RL32(s->buf+12));
> > }
> 
> This block looks weird.

typical quick-hack debug not intended for release
 
[...]
> 
> If you commit this, please don't forget docs, changelog, minor bump, etc.

It will probably be done is several steps anyway.
 
> Diego



More information about the ffmpeg-devel mailing list