[FFmpeg-devel] [PATCH] 'vorbis_residue_decode' optimizations

Michael Niedermayer michaelni
Sun Dec 20 15:09:40 CET 2009

On Sun, Sep 28, 2008 at 03:33:10AM +0300, Siarhei Siamashka wrote:
> So what should we do next in order to have this work finalized and move on to
> other optimizations? There were a few weeks for everyone to comment about the
> patch and run some benchmarks.

Well id rather say there where months for you to fix the issues raised by
comments to this and previous versions of the patch. To finalize this somone
has to fix these issues, the patch in its current state is not commitable.

Some issues i remember
*  you duplicate GET_VLC & SHOW_UBITS, and then add optimizations to the
   duplicated code.
   Optimizations must (not can) be merged into the exising code, a codec
   cannot duplicate code and then add generic optimizations to it that are
   applicable to all other uses outside that codec as well.
*  the consecutive asm statements must be merged
*  All small issues raised by me & loren must be fixed, large restructuring
   is discussable and can probably be done later

> I would prefer to have bitstream related stuff committed separately as it is
> an optimization that is independent from SSE part.

yes, spliting the patch is also something someone (like you) have to do.

Anyway, i must admit your mail feels a little arogantly written, not that i
care about that but it must be clear that messy patches are rejected
and its the authors (or any volunteers) job to clean them up its not that
we review it and then clean it up. There are plenty of patches and other
issues that are in better shape so even if we choose to clean it up its
likely this one wont be in line anytime soon.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091220/b13d3365/attachment.pgp>

More information about the ffmpeg-devel mailing list