[FFmpeg-devel] [PATCH] Add pad filter

Stefano Sabatini stefano.sabatini-lala
Mon Dec 21 23:30:42 CET 2009

On date Sunday 2009-12-20 15:56:11 +0100, Artur Bodera encoded:
> On Sat, Dec 12, 2009 at 6:43 PM, Michael Niedermayer <michaelni at gmx.at>wrote:
> >
> > Besides this, we need regression tests for the filters, i plan to make
> > this mandatory for every new filter now, too many bugs sliped through
> > already.
> > No reg test for a filter -> no approval.
> >
> Now I need why :-) This filter is eating up all my machine's memory as it
> progresses with encoding. Forgot some garbage collection?

Yes indeed, see what I was missing in end_frame().

> btw: why none has commented on the vfilters + -pad[right|top|bottom|left]
> bug ?
> When trying to use any of the built-in padding modifiers together with
> -vfilters, the resulting video is always garbled green-ish confetti.

Those options are meant to be dropped soon (I'm considering to do that
in the libavfilter repo as soon as we'll have the pad filter
committed), so I'm simply ignoring those bugs.

Attached an updated version, let me know if you find other problems
with it.

FFmpeg = Fundamental & Forgiving Minimalistic Programmable Educated Gadget
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-pad-filter.patch
Type: text/x-diff
Size: 14229 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091221/cbff420a/attachment.patch>

More information about the ffmpeg-devel mailing list