[FFmpeg-devel] [PATCH] Use all 32 bits of the timestamp when calculating flv duration

Michael Niedermayer michaelni
Sun Dec 27 14:16:03 CET 2009


On Thu, Sep 03, 2009 at 04:48:44PM +0300, Martin Storsj? wrote:
> On Thu, 3 Sep 2009, Michael Niedermayer wrote:
>
>> On Thu, Sep 03, 2009 at 04:18:50PM +0300, Martin Storsj? wrote:
>>>
>>> $subj. At the moment, the duration is mainly set from the metadata 
>>> packet,
>>> but if that isn't available, the fallback by checking the timestamp of 
>>> the
>>> last packet really should read all 32 bits of the timestamp, not just the
>>> low 24 bits as currently.
>>
>> ok if its confirmed that this does fix a bug
>
> Yes, I tested it that it fixes a bug, otherwise the duration is wrong for 
> all files over 4,6 hours.
>
> Attached a version that adds proper spacing around the equals sign, so that 
> we clean up whitespace for lines that we're touching anyway.
>
>> also the code could maybe be factored out, we have that 24+8 reading in 
>> there
>> twice
>
> That might be a good idea...
>
> // Martin

>  flvdec.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> a66ab2d64ca9794ddc2f21c235828f13e65b1ae7  flv-duration.patch

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091227/e9354240/attachment.pgp>



More information about the ffmpeg-devel mailing list