[FFmpeg-devel] [PATCH] RTSP-MS 14/15: ASF packet parsing
Ronald S. Bultje
Tue Feb 3 14:08:15 CET 2009
On Tue, Feb 3, 2009 at 7:38 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Jan 06, 2009 at 12:18:39AM -0500, Ronald S. Bultje wrote:
>> + if (!rt->asf_ctx)
>> + return -1;
> can this happen?
In a broken stream, yes. It happens when the header is not present in the SDP.
>> + len_off = (get_byte(gb)<<16)|(get_byte(gb)<<8)|get_byte(gb);
> does this have defined behavior in C?
Can I implement a get_[bl]e24()? I'll probably make this mistake
again. (And yes, I think the behaviour is undefined.)
(Will fix the rest in my next patch resubmission.)
More information about the ffmpeg-devel