[FFmpeg-devel] [PATCH]Basic XSUB encoder (take 4)

Reimar Döffinger Reimar.Doeffinger
Thu Feb 5 22:15:30 CET 2009


On Thu, Feb 05, 2009 at 10:04:18PM +0100, Bj?rn Axelsson wrote:
> +    // Enforce total height to be be multiple of 2
> +    if (h->rects[0]->h & 1)
> +        put_xsub_rle(&pb, h->rects[0]->w, PADDING_COLOR);

Is there a buffer size check for that line of code?

> +    flush_put_bits(&pb);
> +
> +    return hdr - buf + put_bits_count(&pb)/8;

You need another align_put_bits or you might return one too few here.
I think I have no further comment, I'd appreciate if others could review
the build system and other stuff...




More information about the ffmpeg-devel mailing list