[FFmpeg-devel] [PATCH] fix crash in vp3.c

Alex Converse alex.converse
Fri Feb 6 00:06:12 CET 2009


2008/12/24 Michael Niedermayer <michaelni at gmx.at>:
> On Wed, Dec 24, 2008 at 06:09:57PM +0100, Diego Biurrun wrote:
>> Here is a patch from Nico Golde that I found in the Debian bug tracker.
>> It fixes the crash I experience on my PPC box with
>>
>> http://caca.zoy.org/attachment/wiki/zzuf/bugs/lol-ffplay.ogm
>
> this patch is incorrect and insufficient
>
> the first (though this might not be the only) bug is that
> the return of read_huffman_tree() is ignored, that is errors are not
> passed on to the caller
>
> [...]

Correct.

The attached patch fixes that. The file in question no longer crashes ffmpeg.

Regards,
Alex Converse
-------------- next part --------------
A non-text attachment was scrubbed...
Name: issue775-handle-read_huffman_tree-failure.diff
Type: text/x-diff
Size: 1472 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090205/18533db4/attachment.diff>



More information about the ffmpeg-devel mailing list